is this correct?

Is this considered to be incorrect usage of a preposition? "Why did you do that for?"

You should say

What did you do that for?
or
Why did you do that?

You don't need a preposition with 'why' here. ;-)