Did I do what I said I would?
I saw this sentence from someone email signature.
I am not sure whether the grammar is correct. (especially the blue color)
Looks fine to me. What do you think is not right?
not a teacher
How about this:
E.g.
You had learnt English before you moved to New York.
You learnt English before you moved to New York.
Are they correct and having the same meaning?
If yes, then I don't need to use past perfect tense in most cases.
And please tell me what situation must be used as past perfect tense not past tense.
***** NOT A TEACHER *****
Here is some advice from L.G. Alexander in his very popular Longman English
Grammar:
There are instances in which we need to be very precise in our use of past or
past perfect, particularly with when:
When I arrived, Anne left. (at that moment)
When I arrived, Anne had left. (before I got there)