Re: When with Present Perfect
It's OK. While 'when?' usually suggests 'at what time in the past?', it can be used with the idea of 'in the whole period extending up to now, has this happened? (and if so, when?)' The emphasis is more on whether the situation existed than on the specific time-point. Compare:
Originally Posted by englishhobby
A: I was in love with with all three brothers an one point or another?
B: Oh? When were you in love with Peter?
A: Being in love can be a painful experience.
B: Huh. When have you ever been in love?
Please do not edit your question after it has received a response. Such editing can make the response hard for others to understand.