past perfec continous vs. past simple

Status
Not open for further replies.

CarloSsS

Senior Member
Joined
Aug 8, 2010
Member Type
Student or Learner
Native Language
Czech
Home Country
Czech Republic
Current Location
Czech Republic
Is this sentence correct?

Before you came here, how long had you been working in Spain?

I'd say this instead:

Before you came here, for how long did work in Spain?

Or maybe they're both all right but there's a difference in meaning?
 

bhaisahab

Moderator
Staff member
Joined
Apr 12, 2008
Member Type
Retired English Teacher
Native Language
British English
Home Country
England
Current Location
Ireland
Is this sentence correct?

Before you came here, how long had you been working in Spain?

I'd say this instead:

Before you came here, for how long did work in Spain?

Or maybe they're both all right but there's a difference in meaning?

They are both correct. I would use the first. There is no difference in meaning.
 

MikeNewYork

VIP Member
Joined
Nov 13, 2002
Member Type
Academic
Native Language
American English
Home Country
United States
Current Location
United States
Is this sentence correct?

Before you came here, how long had you been working in Spain?

I'd say this instead:

Before you came here, for how long did work in Spain?

Or maybe they're both all right but there's a difference in meaning?

There is a word missing in your version.
 

CarloSsS

Senior Member
Joined
Aug 8, 2010
Member Type
Student or Learner
Native Language
Czech
Home Country
Czech Republic
Current Location
Czech Republic
How about the register, is there a difference as far as the register is concerned? And what about the variety of English? Is there no difference there either?
 

MikeNewYork

VIP Member
Joined
Nov 13, 2002
Member Type
Academic
Native Language
American English
Home Country
United States
Current Location
United States

engee30

Key Member
Joined
Apr 1, 2006
Member Type
Retired English Teacher
Native Language
Polish
Home Country
Poland
Current Location
England
CarloSsS, as a rule of thumb - before and after don't usually require a perfect tense as they both already tell you about the sequence of events, unlike when, in which case you need to use a proper tense to get your message across properly.
 

MikeNewYork

VIP Member
Joined
Nov 13, 2002
Member Type
Academic
Native Language
American English
Home Country
United States
Current Location
United States
Is this sentence correct?

Before you came here, how long had you been working in Spain?

I'd say this instead:

Before you came here, for how long did work in Spain?

Or maybe they're both all right but there's a difference in meaning?

There is nothing wrong with "how long had you been working in Spain". But because of the timing clue provided by "before you came here" the verb "were" would be acceptable.
 
Status
Not open for further replies.
Top