My source says:
The Oxford English Dictionary's earliest citation for it is from its 1942 mention in The American Thesaurus of Slang , but in Steinbeck's 1938 The Grapes of Wrath. there appears: "'How ya keepin' yaself?' 'Full a piss an' vinegar.'" If Steinbeck had a character use a phrase in speech and didn't gloss it - (make it less 'vulgar') - then the phrase had to have already been familiar for some time before he recorded it. There are also plenty of citations going forward from that date, all the way up to Bart's declaration in a 1994 episode of The Simpsons: "I'm full of piss and vinegar."
However, we still haven't turned up anything earlier than the Steinbeck citation, which makes it hard to know where the phrase comes from. There is certainly a similar expression with the identical meaning, "full of beans," which goes back to 1854. There's an expression, "full of piss and wind", which means 'full of blustering talk; pretentious' that dates to 1922. There's also Kyne's "He's full of pep and vinegar" (They Also Serve, 1927) that may indicate a euphemistic treatment of "piss"; certainly the sense of vinegar alone meaning 'vitality' was already part of campus slang in the 1920s.
It could just be that the 1920s provenances of vinegar meaning 'vim',"piss and wind," and "pep and vinegar" all combine to mean that some slick-haired co-ed came up with the combination of pungent liquids in the expression. In fact, they've been combined before: there is an expression "to piss vinegar" that goes back to 1602, meaning 'to be miserly'. This gave rise to the 18th-century "vinegar-pisser," a 'miser'. If there is any connection between these meanings and piss-and-vinegar vitality, it seems exactly the sort that a college student might make.