The tense is fine.
Whether "take" or "bring" is the correct word to use depends on the exact meaning of the sentence. "Bring" usually implies motion towards the speaker; "Take" implies motion anywhere else.
For example, if you are planning to visit me, and we are talking about it on the phone, I might say to you: "You should bring an umbrella..." But if you are already at my house and planning to leave, and there are dark clouds overhead, I might offer you one of my umbrellas and say, "You should take an umbrella..."
But what if, for example, we are planning to go for a walk together? We are moving away from where we are at the moment, but you're not actually taking an umbrella away from me. Then I could use either "bring" or "take", and they would be interchangeable.
- For Teachers