Verona: Tense 'markers' such as for, since, already, just etc normally help us choose a tense. If we don't have them, there can be some ambiguity
When I came, they were drinking champagne ( they were in the process of drinking)
When I came, they had been drinking champagne (I saw half-empty bottles, the people were slightly drunk)
When I came, they had drunk the champagne (the bottles were empty, a guy sleeping under the table)
One of the problems here is that some course books and grammars give the impression that there is always a ‘right’ answer’, and always only one correct tense. Provided we recognise that, the problem largely disappears. We don’t have to wonder whether tense A is more or less appropriate than tense B – they are probably both appropriate for the situation as their speakers see it.
Raymott (Post #2) )"Arrived" is much better than "came" in this situation.
I agree.
2. is possible. I'd prefer, "When I arrived, I noticed they'd been drinking champagne." The fact is that they had been drinking champagne before your arrival, not when you arrived. "Before I arrived, they had been drinking ..." is also good.
I don’t agree. That is not to say that Raymott is wrong, but simply that he would use a different construction than I
3. The same argument goes for this sentence. "They had drunk all the champagne before I arrived." or "By the time I arrived, they had drunk ...".
Once again, I don’t agree.
Verona (Post #3): [FONT="]When the phone rang, I had gone to bed.
When I came home, water had been leaking through the roof.
I hardly see any difference between these sentences and the champagne ones
Neither do I. [/FONT]
[FONT="]Milan[/FONT][FONT="] (Post #4) Frankly speaking I would use Past Simple in sentence #1 [
When the phone rang, I had gone to bed.] because this Tense seems more natural to me in such context:
When the phone rang, I was doing .... (something). [/FONT]
[FONT="]But that is a different situation. In Verona’s example, the going to bed preceded the ringing of the phone.[/FONT][FONT="]
If you want to use Past Perfect it would be better to insert some word like "already":
When the phone rang, I had already gone to bed.
You may feel ‘already’ is necessary, I don’t. Use it if you wish, but don’t insist on it.
Sentence #2 [
When I came home, water had been leaking through the roof.]allows both Past Perfect Continuous and Past Simple.
It does indeed, but there is a slight difference in meaning.[/FONT]
Verona (Post #5)
When I last went to Moscow, they had been renovating St Basil's Cathedral.
When I met Simon and Pat, they had been riding.
And there're no time adverbs. It's mind-boggling.
There is no need for time adverbs (though ‘last’ looks suspiciously like one to me). The situations in both sentences are clearly located in the past.
Milan 6. Your sentences do make sense even without adverbs, but it's still strange to me to see them written this way.
Not strange to me.
If I were to choose a proper Tense to use, I would have chosen Past Continuous in both examples.
The past Continuous is perfectly acceptable, but it suggests a different view of the situation.