"On sale" suggests a discounted price.
"For sale" simply announces the availability of the item, for a price.
"I have some potatoes for sale. Would you like to buy some?"
"Well, they are regularly 50 cents a kilo, but this week only, they are on sale for 45 cents."
Student or Learner