[Grammar] What have you done in the past?

Status
Not open for further replies.

sky3120

Member
Joined
Jan 29, 2012
Member Type
Student or Learner
Native Language
Korean
Home Country
South Korea
Current Location
South Korea
What have you done in the past? VS. What did you do in the past?

I think that the second one is grammatically correct but some people say the first one is also used and correct. What do you think?

Thank you so much as always.
 

BobK

Moderator
Staff member
Joined
Jul 29, 2006
Location
Spencers Wood, near Reading, UK
Member Type
Retired English Teacher
Native Language
English
Home Country
UK
Current Location
UK
Both are grammatically correct, and apply in different situations. Contexts that justify the first outnumber (for me, a speaker of Br Eng) those that justify the second.

b
 
Status
Not open for further replies.
Top