A "fair-weather friend" is more of an idiom describing someone who is not actually a friend. For types of friends in English, you use a basic adjective to modify the noun: "[adjective] + friend".
A "good" friend
A "close" friend
A "best" friend
An "old" friend (old referring to time and not age)
Student or Learner