Student or Learner
I appreciate the answers I've received from many teachers to my questions I've posted.
They are really helpful.
The other day, I was writing in English and I was stuck in this sentence.
ex. Since 2008 whenever I have visited America, I have played the piano with her.
I wasn't sure if it was fine to use "have visited" or I should use a past tense here--whenever I visited America.
With the 'since 2008' I would use the present perfect. The time period extends up to the present.
If the time period did not extend uo to the present, I would use the past simple with 'From/after 2008'.
Thank you for your replies. Because I played with her last year too, and it's likely that I'm going to
play with her again sometime in the future, then I guess I should write
"since 2008 whenever I have visited the US, I have played the piano with her."