Results 1 to 6 of 6
  1. Junior Member
    Interested in Language
    • Member Info
      • Native Language:
      • Ukrainian
      • Home Country:
      • Ukraine
      • Current Location:
      • Ukraine

    • Join Date: Nov 2015
    • Posts: 85
    #1

    I have been doing... before I have done...

    Hello!
    Could you, please, give help on this point?

    I have been looking for my keys for 20 min before I have finally found them in the pocket.

    Is it ok to use present perfect instead of past perfect here?
    Because I often hear a construction ''I've been looking for it for so long. I'm glad I've finally found it'', which seems to convey the same meaning as the sentence above.

  2. Matthew Wai's Avatar
    VIP Member
    Interested in Language
    • Member Info
      • Native Language:
      • Chinese
      • Home Country:
      • China
      • Current Location:
      • Hong Kong

    • Join Date: Nov 2013
    • Posts: 8,118
    #2

    Re: I have been doing... before I have done...

    I had been looking for my keys for 20 minutes when I finally found them in the pocket.
    I am not a teacher.

  3. Piscean's Avatar
    VIP Member
    Retired English Teacher
    • Member Info
      • Native Language:
      • British English
      • Home Country:
      • Europe
      • Current Location:
      • Czech Republic

    • Join Date: Jul 2015
    • Posts: 13,481
    #3

    Re: I have been doing... before I have done...

    Quote Originally Posted by Iryn_ View Post

    I have been looking for my keys for 20 minutes before I have finally found them in the pocket.
    You cannot use a present perfect for an action/state in a time-period leading up to a past time.

    ''I've been looking for it for so long. I'm glad I've finally found it''
    Both actions/states take place in a time period leading up to the present time, or a least a time-point very close to the present moment. This can be said only a very short time after the finding of whatever it is.
    Last edited by emsr2d2; 31-Jan-2017 at 14:11. Reason: Fixed typo

  4. Junior Member
    Interested in Language
    • Member Info
      • Native Language:
      • Ukrainian
      • Home Country:
      • Ukraine
      • Current Location:
      • Ukraine

    • Join Date: Nov 2015
    • Posts: 85
    #4

    Re: I have been doing... before I have done...

    did I understand you well?
    I can use present perfect tenses if it's 2 separate sentences, but if I use "before" to combine them, it already gives an idea of a point in the past, that's why only past perfect is is appropriate?

  5. Piscean's Avatar
    VIP Member
    Retired English Teacher
    • Member Info
      • Native Language:
      • British English
      • Home Country:
      • Europe
      • Current Location:
      • Czech Republic

    • Join Date: Jul 2015
    • Posts: 13,481
    #5

    Re: I have been doing... before I have done...

    Quote Originally Posted by Iryn_ View Post
    did I understand you well?
    I can use present perfect tenses if it's 2 separate sentences,
    Not necessarily. What is important is the time period we have in mind.

    My wife has just phoned to say that she's found her wedding ring. I'm glad she has found it. We were looking for it until past midnight.

    My wife has just phoned to say that she's found her wedding ring. I'm glad she has found it. We have been looking for it for days.
    Last edited by emsr2d2; 31-Jan-2017 at 14:11. Reason: Fixed typo

  6. Matthew Wai's Avatar
    VIP Member
    Interested in Language
    • Member Info
      • Native Language:
      • Chinese
      • Home Country:
      • China
      • Current Location:
      • Hong Kong

    • Join Date: Nov 2013
    • Posts: 8,118
    #6

    Re: I have been doing... before I have done...

    Quote Originally Posted by Iryn_ View Post
    if I use "before" to combine them, it already gives an idea of a point in the past, that's why only past perfect is is appropriate?
    I think the past simple suffices, as in 'I looked for my keys for 20 minutes before I found them'.
    I am not a teacher.

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •