What have you done in the past? VS. What did you do in the past?
I think that the second one is grammatically correct but some people say the first one is also used and correct. What do you think?
Thank you so much as always.
Printable View
What have you done in the past? VS. What did you do in the past?
I think that the second one is grammatically correct but some people say the first one is also used and correct. What do you think?
Thank you so much as always.
Both are grammatically correct, and apply in different situations. Contexts that justify the first outnumber (for me, a speaker of Br Eng) those that justify the second.
b