Idiom: Every cloud has a silver lining.
Please check in the following sentence whether the dash followed by seven years of ... should be replaced by a comma or semi-colon.
His brothers had sold him into slavery, and he was later put in prison. However, it was his prison connections that led Joseph to the Pharaoh for whom he successfully interpreted a coming dream - seven years of famine followed seven years of plenty. Brothers, don't give up easily as every cloud has a silver lining!
Thank you so much.