[Grammar] did visit when lived were living

[mukherjeenandita]

Which of them is correct?

1.Did you ever visit Barcelona when you lived in Spain?
OR
Did you ever visit Barcelona when you were living in Spain?

 

[teechar]

Re: Which of them is correct ?

Hello there, and welcome to the forum.
Both are possible.
The past simple can be used to talk about an action of some duration in the past.

Note that I changed the title of your thread. In future, please include keywords from the post in the title.