I thanked him....

[Banglardon]

What is the difference between the two sentences? Which tense is correct?


1- I thanked him for what he had done.


2- I thanked him for what he did.

 

[Charlie Bernstein]

Both tenses are fine. In some cases, they can mean the same thing. It depends on the context.

Number 2 might include something he was still doing. For example: When I found out he was a veterinarian, I thanked him for what he did.

There's no suggestion that he had stopped being a vet. When I thanked him, he might still have been a vet.

But in 1, whatever he did is over now. It's done. It's in the past. He's not doing it now.

 

[jutfrank]

The difference is in what we call aspect. The first is past perfect and the second is past simple.

The different aspects mean that these two sentences can be used in different ways.

[cross-posted]

 

[Banglardon]

The difference is in what we call aspect. The first is past perfect and the second is past simple.

The different aspects mean that these two sentences can be used in different ways.

[cross-posted]

Could you please explain when I should use them?

 

[jutfrank]

We don't teach lessons here on the forum. I suggest you do some independent studying on the past perfect.

If there's anything you don't understand, come back and ask us, making sure that you bring an example with plenty of context. The only way to understand the past perfect properly is with relevant accompanying context. You shouldn't really use single sentences in isolation.