My father worked for a bank.

[nininaz]

My father has retired for years.

Which sentence is correct now?

My father worked for a bank. In fact, he was a bank branch manager.

My father worked for a bank. In fact, he used to be a bank branch manager.

Is the following correct as well?
My mother was a teacher. She taught in elementary school.

 

[Rover_KE]

Your first sentence is ungrammatical. It should be 'My father has been retired for years' or 'My father retired years ago'.

The subsequent sentences make no mention of his retirement, and each pair of sentences can easily be merged into a single elegant one.

 

[jutfrank]

nininaz, please don't change your posts after you receive a response.

The sentences are correct now. In British English, we'd say She taught at primary school.

 

[nininaz]

nininaz, please don't change your posts after you receive a response.

The sentences are correct now. In British English, we'd say She taught at primary school.

Sorry. But After I made the second change I didn't got any answer.

 

[nininaz]

and each pair of sentences can easily be merged into a single elegant one.

My father worked for a bank and he was a bank branch manager.
Is it correct?

 

[Rover_KE]

Repetition of 'bank' makes it inelegant.

'My father was a bank branch manager.'

If you have a good reason to include 'in fact', say

'My father worked for Cheetham's Bank – as a branch manager, in fact'.

 

[teechar]

Cheetham's Bank – as a branch manager

Was that in the Swindleton branch?

 

[Rover_KE]

Yes—his name's Willie Diddlum.

 

[tzfujimino]

I googled the word 'diddlum'.
https://blog.oxforddictionaries.com/2017/08/24/free-the-word-3/
(Now I think I understand the joke.)