I'd say "on the lottery".I'd use in the lottery, but I think on is OK too- you win money on the horses, etc, in the UK at least.
If you have a question about the English language and would like to ask one of our many English teachers and language experts, please click the button below to let us know: