[Name] has been/was my student when ...

[mrmvp]

I'm writing a letter of recommendation for one of my students. He took a subject with me and earned 91 (A) in 2024. I am puzzled about whether I should use the present perfect or simple past

Should I say:
1- [Last name] has been my student when he attended my classes on [subject name] in 2024.

2- [Last name] was my student when he attended my classes on [subject name] in 2024.

Both tenses seem possible to me, and I have seen both used in recommendation letters. I tend to use past simple because the action is finished and he is not longer with me in any subject.

 

[Skrej]

Only #2 is possible. #1 is incorrect with 'when'. If he's still your student, you could change 'when' to 'since'. However, if he's no longer taking classes with you, then use #2.